Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Maintain backward compatibility of LinkedQueue #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 23, 2024
Merged

Maintain backward compatibility of LinkedQueue #8784

merged 6 commits into from
Apr 23, 2024

Conversation

@ghostdogpr
Copy link
Member

@ghostdogpr ghostdogpr commented Apr 23, 2024 •
edited
Loading

We are getting a runtime error when using zio-cache with the latest zio snapshot because the constructor of LinkedQueue has been changed. To avoid that, keep LinkedQueue with metrics and directly use ConcurrentLinkedQueue where we don't need metrics.

Error was:

Exception in thread "zio-fiber-1942575583" java.lang.NoSuchMethodError: zio.internal.LinkedQueue: method 'void ()' not found
at zio.cache.Cache$CacheState$.initial(Cache.scala:369)
at zio.cache.Cache$.$anonfun$makeWithKey$3(Cache.scala:143)

@ghostdogpr ghostdogpr requested a review from kyri-petrou April 23, 2024 01:06
@ghostdogpr ghostdogpr merged commit 36c5641 into zio:series/2.x Apr 23, 2024
@ghostdogpr ghostdogpr mentioned this pull request May 14, 2024
Closed
guizmaii added a commit that referenced this pull request Apr 8, 2025
@guizmaii
Bring back the addMetrics optimization of LinkedQueue to improve …
faa2fea 
…performances of `Queue.unbounded`

See also:
- #8784
- #8745
@guizmaii guizmaii mentioned this pull request Apr 8, 2025
Merged
guizmaii added a commit that referenced this pull request Apr 8, 2025
@guizmaii
Bring back the addMetrics optimization of LinkedQueue to improve …
eb77066 
…performances of `Queue.unbounded`

See also:
- #8784
- #8745
guizmaii added a commit that referenced this pull request Apr 8, 2025
@guizmaii
Bring back the addMetrics optimization of LinkedQueue to improve …
7745a99 
…performances of `Queue.unbounded`

See also:
- #8784
- #8745
guizmaii added a commit that referenced this pull request Apr 9, 2025
@guizmaii
Bring back the addMetrics optimization of LinkedQueue to improve …
930437a 
…performances of `Queue.unbounded` (#9762)

* Bring back the `addMetrics` optimization of `LinkedQueue` to improve performances of  `Queue.unbounded`

See also:
- #8784
- #8745

* Review: prefer `<field> ne null` over using `addMetrics`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyri-petrou kyri-petrou kyri-petrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ghostdogpr @kyri-petrou