Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@neo773
Copy link
Contributor

@neo773 neo773 commented Sep 3, 2024

This PR migrates Docusaurus to v3

These PRs need to be merged first
zio/zio-logging#881
zio/zio-quill#3083
zio/zio-http#3088
zio-archive/zio-crypto#293

a_videoloop.mp4

/closes #9162
/claim #9162

@987Nabil
Copy link
Contributor

987Nabil commented Sep 6, 2024

@neo773 CI is red for zio/zio-quill#3083

@neo773
Copy link
Contributor Author

neo773 commented Sep 6, 2024

@kyri-petrou
Copy link
Contributor

@neo773 can you take a look at the current CI failure? Not entirely sure what's causing it

@neo773
Copy link
Contributor Author

neo773 commented Nov 4, 2024

@kyri-petrou
Some of the linked PRs haven't been merged yet and released on npm.
Build fails because the document breaks with MDX parser in Docusaurus v3

Check PR's body

@kyri-petrou
Copy link
Contributor

Some of the linked PRs haven't been merged yet and released on npm.

AFAICT all the PRs have been merged in. Or do we need to make releases for each library as well?

@neo773
Copy link
Contributor Author

neo773 commented Nov 4, 2024

Some of the linked PRs haven't been merged yet and released on npm.

AFAICT all the PRs have been merged in. Or do we need to make releases for each library as well?

My bad, it's been a while since I made this PR.

Yes, you'll need to release a new version on npm since that's where the build process fetches the markdown files from.

@987Nabil
Copy link
Contributor

987Nabil commented Nov 6, 2024

I think zio crypto might be dead. Maybe we should exclude it

@jdegoes
Copy link
Member

jdegoes commented Nov 8, 2024

@neo773 Can you remove zio-crypto? Would love to get Docusaurus upgraded!

cc @khajavi

@neo773
Copy link
Contributor Author

neo773 commented Nov 9, 2024

zio-quill needs an npm release update, apart from that looks good to go

@khajavi
Copy link
Member

khajavi commented Nov 9, 2024

zio-quill needs an npm release update, apart from that looks good to go

@neo773 The npm release is not separate from the library release. So, can you file an issue on the zio-quill repo and ask the maintainers for the next release?

@kyri-petrou
Copy link
Contributor

@neo773 can you also remove zio-keeper? Seems to be causing the CI failure and that project is not maintained (or ever had a stable release)

@neo773
Copy link
Contributor Author

neo773 commented Nov 26, 2024

So I ran the build again this the last PR that needs to be merged for the migration to complete

zio/zio-dynamodb#544

image

@kyri-petrou

@neo773
Copy link
Contributor Author

neo773 commented Nov 28, 2024

@kyri-petrou
CI is passing now, can we merge?

@@ -0,0 +1 @@
ln -s documentation/guides/tutorials/make-a-zio-app-configurable/docs/make-a-zio-application-configurable.md website/docs/guides/tutorials/ No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that something has gone wrong with the build file that we require this symlink.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that specific guide in documentation folder broke and wasn’t detected during sidebar generation step

I did try looking at the build.sbt file but I’m not really familiar with Scala lang and it’s tooling.

if you have any suggestions for this I’d be happy to look into it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this happen before or after you updated your work to align with the series/2.x branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happened after upgrading docusaurus to v3

@kyri-petrou
Copy link
Contributor

@neo773 I'm okay to merge once @khajavi approves it :)

@kyri-petrou kyri-petrou merged commit cfd2cb7 into zio:series/2.x Dec 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Website: Upgrade Docusaurus to the Latest Version (3.x)

5 participants