Cleanup & update build.sbt #9310
Conversation
| @@ -1,32 +0,0 @@ | |||
| import BuildHelper._ | |||
There was a problem hiding this comment.
@kyri-petrou
Have you checked if the documentation website can include this tutorial after removing the file?
There was a problem hiding this comment.
@khajavi I'm not sure how to check that; where do I need to check?
There was a problem hiding this comment.
If I remember correctly, this project's mdoc commands, compile the document and place it into the website documentation. Removing this project's build file won't generate related documentation materials for the zio website.
There was a problem hiding this comment.
The config from this build.sbt file was moved into the main build.sbt file though (see here)
I also run docs/mdoc and it was definitely being included, although I didn't check the generated artifacts. I'll double check just in case
There was a problem hiding this comment.
@khajavi I just double-checked and this module's documentation is included in the website artifacts (at least the ones generated by mdoc).
Since in the near future we'll be adding a number of new modules to this repo, it's a good idea to clean up and optimize the build as much as possible, and reduce the differences between Scala 2 and Scala 3 builds / CI.
Main changes:
benchmarksfor Scala 3. This required update of akka-streams but this should be OK given that this is only used for benchmarkstest-junit-testsmoduleCrossTypefor modules that do not have platform-specific code toCrossType.Pure. This way we're only creating 3 SBT modules (JVM, JS, Native) when used in IntelliJ as opposed to 7 (JVM, JVM-JS, JVM-Native, JS, JS-Native, Native, Common sources). This required a number of files to be moved from<module-folder>/common/srcto<module-folder>/srcLeaving as draft till CI passes