Replace all internal ZIO.fail(None) with Exit.failNone
#9359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
reviewed
Nov 30, 2024
| for { | ||
| bytesRead <- ZIO.attempt(channel.read(reusableBuffer)).asSomeError | ||
| _ <- ZIO.fail(None).when(bytesRead == -1) | ||
| _ <- Exit.failNone.when(bytesRead == -1) |
There was a problem hiding this comment.
A bit outside of the scope of this PR, but since we're at it might change these usages to whenDiscard
| pull.mapError(error => Some(error)).flatMap { | ||
| case Left(done) => ZIO.fail(None) | ||
| case Right(elem) => ZIO.succeed(elem) | ||
| case Left(done) => Exit.failNone |
There was a problem hiding this comment.
Let's use foldZIO instead of mapError and flatMap in the line above this while we're at it
| bytesRead <- ZIO.attemptBlockingIO(is.read(bufArray)).asSomeError | ||
| bytes <- if (bytesRead < 0) | ||
| ZIO.fail(None) | ||
| Exit.failNone |
There was a problem hiding this comment.
Maybe better done as a separate PR, but maybe we should store Exit.succeed(Chunk.empty) in a val and use it below here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.