Remove internal usages of ZIO.done
#9369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
approved these changes
Dec 3, 2024
Collaborator
hearnadam
left a comment
There was a problem hiding this comment.
Can we also deprecate ZIO.done?
Contributor
Author
@hearnadam good point - done. Initially I thought there might be users that want to suspend a method that produces an Exit, but they can easily use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure why
ZIO.doneexists in the first place; my guess is that it's a hangover back from a time that Exit didn't extend ZIO and had to be lifted into one instead.In any way, this PR removes all internal usages of
ZIO.done(which are surprisingly many) to avoid the additional allocations and runtime loop iterations