Optimize Scope-related methods #9372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
reviewed
Dec 3, 2024
Comment on lines
4654
to
4655
| def scopeWith[R, E, A](f: Scope => ZIO[R, E, A])(implicit trace: Trace): ZIO[R with Scope, E, A] = | ||
| ZIO.serviceWithZIO[Scope](f) | ||
| FiberRef.currentEnvironment.getWith(env => f(env.unsafe.getScope(Unsafe))) |
Collaborator
There was a problem hiding this comment.
This is 'safe' because of with Scope?
Contributor
Author
There was a problem hiding this comment.
Yes. It's not any different than what was happening previously. The only thing that is making things "safe" is that the Scope is that Scope needs to be erased from R. Unsafely casting the type to remove the Scope from the requirement will cause a runtime error (both previously and now)
hearnadam
reviewed
Dec 5, 2024
hearnadam
approved these changes
Dec 9, 2024
# Conflicts: # core/shared/src/main/scala/zio/ZEnvironment.scala
regiskuckaertz
approved these changes
Dec 9, 2024
Member
|
I wonder if it improves the streaming benchmarks 😇 |
Contributor
Author
|
@regiskuckaertz there seems to be a 5-10% improvement in the series/2.x PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (micro)-optimizes various methods related to usage of
Scopein ZIO. The main optimizations come from reducing the number of flatMaps and unnecessary object creation / Long boxing when creating / closing a forkedScope(which happens a lot particularly inZStreammethods). It also optimizes Scope access (viaZIO.scope/ZIO.scopeWith) by adding a new accessor method to ZEnvironment for retrieving the Scope within it, bypassing the need to check the service tag.