Regis' review: Prefer Result over Exit
#9445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1503ddc to
7c2da21
Compare
Result over ExitResult over Exit
847406d to
cb692ba
Compare
cb692ba to
af713d9
Compare
|
I merged because I think it's worth it. |
guizmaii
added a commit
that referenced
this pull request
Dec 31, 2024
guizmaii
added a commit
that referenced
this pull request
Jan 7, 2025
guizmaii
added a commit
that referenced
this pull request
Jan 11, 2025
kyri-petrou
added a commit
that referenced
this pull request
Jan 18, 2025
* Simplify `zio.stream.ZChannel.mergeAllWith` code * Review: Prefer `*>` * Review: Remove as many `.map` and `.flatMap` calls as possible (#9387) * Review: Remove as many `.map` calls as possible * Update streams/shared/src/main/scala/zio/stream/ZChannel.scala * Remove Option in `lastDone` `Ref` * `SingleProducerAsyncInput.unsafe.make` * `fiberIdWith` * success first * fmt * Clean * Regis review: Prefer `Exit` over `ZIO` * Regis review: Prefer `Result` over `Exit` (#9445) * Review: Remove `Result` methods * Review: Remove `ZIO.suspendSucceed` * Review: Prefer `AtomicReference` * Review: Prefer `Unsafe` * Review: Improve `zio.stream.internal.SingleProducerAsyncInput.unsafe.make` * Fix tests * Rollback `AtomicReference` change * uninterruptible finalizers * Fix imports * clean code * Fix wrong `.map` usage * Put back `AtomicReference` --------- Co-authored-by: kyri-petrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets this other PR: #9383
It's exploring the idea expressed here: #9383 (comment)
Let me know if you like the idea. I think it simplifies the code and removes some allocations, that's why I think it's worth it