Reduce parallelism of ZStreamSpec
#9464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9443
Issue seems to be related to the heavy usage of
TestClockinZStreamSpec. Because parallelism is applied per-suite, in cases of nested suites (whichZStreamSpeccontains a lot of!) with the default parallelism of 4 the number of suites running in parallel can be up to 4 x 4 x 4 = 64.This causes issues with
TestClockbecause it "awaits" (usingsleep) for all the fibers spawned within the test to be suspended. However, when there is a large number of suites running in parallel, it might falsely determine that a fiber has suspended when it hasn't started running yet. This can cause the suite to deadlock as some test is awaiting for theTestClockto advance, when it already has