Ensure Supervisor#onEnd is called exactly once
#9537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Feb 3, 2025
| if (supervisor ne Supervisor.none) supervisor.onSuspend(self)(Unsafe) | ||
| if (supervisor ne Supervisor.none) { | ||
| if (finalExit ne null) supervisor.onEnd(finalExit, self)(Unsafe) | ||
| supervisor.onSuspend(self)(Unsafe) |
There was a problem hiding this comment.
I think there should probably be an else statement here, but I'm worried this might cause issues in cases we're expecting the onSuspend method to be called regardless whether we've suspended or exited so I decided to leave it as it was (with onEnd being called first as that was the behaviour previously)
jdegoes
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9494
It seems that in in ZIO 2.0.x we were relying on calling
onEndonly by adding an observer when we forked the fiber. Some time in the development of ZIO 2.1 theonEndmethod was also being called within theFiberRuntime.evaluateEffect, causing it to be called twice.This PR delegates the responsibility of calling
onEndentirely to theFiberRuntimeinstead of relying on externally adding an observer.