Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Mark Fiber as sealed #9554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Mark Fiber as sealed #9554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2c80e4
Mark `Fiber` as sealed
hearnadam Feb 6, 2025
b5e9567
address feedback
hearnadam Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions core/shared/src/main/scala/zio/Fiber.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import zio.internal.WeakConcurrentBag
* } yield (a, b)
* }}}
*/
abstract class Fiber[+E, +A] { self =>
sealed abstract class Fiber[+E, +A] { self =>

/**
* Same as `zip` but discards the output of the left hand side.
Expand Down Expand Up @@ -742,11 +742,11 @@ object Fiber extends FiberPlatformSpecific {
}

sealed trait Status { self =>
def isDone: Boolean = self match { case Status.Done => true; case _ => false }
def isDone: Boolean = self eq Status.Done

def isRunning: Boolean = self match { case _: Status.Running => true; case _ => false }
def isRunning: Boolean = self.isInstanceOf[Status.Running]

def isSuspended: Boolean = self match { case _: Status.Suspended => true; case _ => false }
def isSuspended: Boolean = self.isInstanceOf[Status.Suspended]
}
object Status {
sealed trait Unfinished extends Status {
Expand All @@ -763,7 +763,7 @@ object Fiber extends FiberPlatformSpecific {
final case class Running(runtimeFlags: RuntimeFlags, trace: Trace) extends Unfinished {
override def toString(): String = {
val currentLocation =
if (trace == Trace.empty) "<trace unavailable>"
if ((trace eq Trace.empty) || (trace eq null)) "<trace unavailable>"
else trace

s"Running(${RuntimeFlags.render(runtimeFlags)}, ${currentLocation})"
Expand All @@ -776,7 +776,7 @@ object Fiber extends FiberPlatformSpecific {
) extends Unfinished {
override def toString(): String = {
val currentLocation =
if (trace == Trace.empty) "<trace unavailable>"
if ((trace eq Trace.empty) || (trace eq null)) "<trace unavailable>"
else trace

s"Suspended(${RuntimeFlags.render(runtimeFlags)}, ${currentLocation}, ${blockingOn})"
Expand Down
Loading