fix: Flaky broadcastDynamic tests (#9555) #9557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
reviewed
Feb 7, 2025
| )(implicit trace: Trace): ZIO[R with Scope, Nothing, Chunk[Dequeue[Take[E, A]]]] = | ||
| for { | ||
| hub <- Hub.bounded[Take[E, A]](maximumLag) | ||
| hub <- ZIO.acquireRelease(Hub.bounded[Take[E, A]](maximumLag))(_.shutdown) |
There was a problem hiding this comment.
From what I can tell, broadcastDynamic doesn't use this method (It uses broadcastedQueuesDynamic below)
There was a problem hiding this comment.
That's true, but that's part of the test suite which is right before the test suite broadcastDynamic. I imagine we need to close the Hub just like we close it in out test suite.
There was a problem hiding this comment.
You are totally right, this has nothing to do with the point of the issue. I just removed it.
kyri-petrou
reviewed
Feb 7, 2025
kyri-petrou
reviewed
Feb 10, 2025
| } yield assertTrue(cleaned) | ||
| } | ||
| ) @@ TestAspect.timeout(5.seconds) @@ flaky, | ||
| ) @@ TestAspect.timeout(5.seconds), |
There was a problem hiding this comment.
Can we add @@ nonFlaky as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix Issue #9555 by
It makes now even more sense to change the signature of the function
broadcastDynamicas you mention in previous issue #9474