Optimise ZChannel::mapOutZIOParUnordered code
#9602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1dcdf90 to
37107c5
Compare
37107c5 to
50e7dd7
Compare
ad06a2b to
771e128
Compare
guizmaii
commented
Feb 16, 2025
| f: OutElem => ZIO[Env1, OutErr1, OutElem2] | ||
| )(implicit trace: Trace): ZChannel[Env1, InErr, InElem, InDone, OutErr1, OutElem2, OutDone] = | ||
| )(implicit trace: Trace): ZChannel[Env1, InErr, InElem, InDone, OutErr1, OutElem2, OutDone] = { | ||
| sealed trait ResultUnordered |
There was a problem hiding this comment.
I couldn't name it Result. Mima was complaining. Probably clashing with the Result in mergeAllWith
zio.stream.ZChannel::mapOutZIOParUnordered codeZChannel::mapOutZIOParUnordered code
|
@kyri-petrou This PR is ready for review :) |
kyri-petrou
reviewed
May 1, 2025
| outgoing.offer(ResultUnordered.Failure) | ||
| case Left(x: Right[OutErr, OutDone]) => | ||
| permits.withPermits(n0)(ZIO.unit).interruptible *> | ||
| outgoing.offer(ResultUnordered.Done(x.value)) |
There was a problem hiding this comment.
This would previously offer an Exit.Failure(Right(...)) but now it offers a Done instead of Failure. Is that intended?
There was a problem hiding this comment.
Comment on lines
-813
to
-814
| case Right(c) if c.isInterruptedOnly => ZChannel.refailCause(failure0) | ||
| case Right(cause) => ZChannel.refailCause(cause) |
There was a problem hiding this comment.
I think it was possible (old L793)
|
Closed in favour of #10080 as the rebase was becoming impossible Sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar changes to those made in #9383 and #9556
Also took these changes into consideration in this PR: #9478