Add ZPipeline::mapEitherChunked
#9757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce7616f to
196637d
Compare
051f7a2 to
9156fe7
Compare
9156fe7 to
7e857e6
Compare
guizmaii
commented
Apr 7, 2025
| * | ||
| * Will stop on the first Left found | ||
| */ | ||
| def mapEitherChunked[Env, Err, In, Out]( |
There was a problem hiding this comment.
I hesitated between mapEither and mapEitherChunked
kyri-petrou
reviewed
Apr 8, 2025
| )(implicit trace: Trace): ZPipeline[Env, Err, In, Out] = { | ||
| lazy val reader: ZChannel[Env, Err, Chunk[In], Any, Err, Chunk[Out], Any] = | ||
| ZChannel.readWithCause( | ||
| chunk => { |
There was a problem hiding this comment.
Since destroying chunking is not uncommon, I'm wondering whether we should shortcut chunk.size == 1
There was a problem hiding this comment.
It's a good idea! Thanks :)
Done
kyri-petrou
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.