Add ZPipeline::mapChunksEither
#9775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6637a1 to
6b72413
Compare
|
|
guizmaii
commented
Apr 10, 2025
| lazy val reader: ZChannel[Env, Err, Chunk[In], Any, Err, Chunk[Out], Any] = | ||
| ZChannel.readWithCause( | ||
| chunk => { | ||
| if (chunk.isEmpty) reader |
Member
Author
There was a problem hiding this comment.
I'm not actually sure this is the correct behaviour. The user might want to deal with the "empty chunk" case and decide to return a Left or Right in this case, no? 🤔
Contributor
There was a problem hiding this comment.
Is it even possible to have an empty chunk? If so we should definitely pass it to f(_), which means that either way we shouldn't handle .isEmpty
Member
Author
There was a problem hiding this comment.
Is it even possible to have an empty chunk?
This is a good question. I don't know.
I made the change
859ff38 to
c9745c8
Compare
hearnadam
previously approved these changes
Apr 11, 2025
streams-tests/shared/src/test/scala/zio/stream/ZPipelineSpec.scala
Outdated
Show resolved
Hide resolved
streams-tests/shared/src/test/scala/zio/stream/ZPipelineSpec.scala
Outdated
Show resolved
Hide resolved
…cala Co-authored-by: Adam Hearn <[email protected]>
…cala Co-authored-by: Adam Hearn <[email protected]>
Member
Author
|
@hearnadam I need another approval as I merged your suggestions 😅 |
hearnadam
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.