Optimize Queue#shutdown
#9770
Merged
Optimize Queue#shutdown
#9770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Apr 9, 2025
| else { | ||
| val as = unsafePollAll(queue) | ||
| if (as.nonEmpty) { | ||
| if (!as.isEmpty) { |
Contributor
Author
There was a problem hiding this comment.
Note that I noticed a few nonEmpty calls. This is a micro-optimization as isEmpty is implemented directly on Chunk but nonEmpty requires an interface method dispatch which is very slow
Collaborator
There was a problem hiding this comment.
I think we need to override knownSize in Chunk.
Collaborator
There was a problem hiding this comment.
Actually, IndexedSeq overrides knownSize: https://github.com/scala/scala/blob/483b4ee34aa8957709f5ab8bc63a69a069949e4b/src/library/scala/collection/IndexedSeq.scala#L118
hearnadam
reviewed
Apr 9, 2025
| def surplusSize: Int | ||
|
|
||
| def shutdown(implicit trace: Trace): UIO[Unit] | ||
| def shutdown(fiberId: FiberId)(implicit trace: Trace, unsafe: Unsafe): Unit |
Collaborator
There was a problem hiding this comment.
could this be protected?
Contributor
Author
There was a problem hiding this comment.
Not really, since it's called by Queue. But it's OK because Strategy is a private class
hearnadam
approved these changes
Apr 9, 2025
guizmaii
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
Queue#shutdownwas quite unoptimized while looking at a different PR.At the moment
Queue#shutdownis quite heavy for the calling thread, as it involves a lot of ZIO's in addition to completing Promises in parallel unnecessarily. With this PR we avoid all of this which should make queue shutdowns a lot faster. While most workflows won't see much of a performance benefit from this change, certain workflows that rely on creation of queues for streams will definitely benefit from these changes.