Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kyri-petrou
Copy link
Contributor

No description provided.

guizmaii
guizmaii previously approved these changes Apr 10, 2025
@kyri-petrou
Copy link
Contributor Author

Eghh so scala.jdk.CollectionConverters._ is only available when the scala-collection-compat library is present.

I think it's time to include it as a dependency; besides having to write unoptimized or lots of custom code to accommodate for methods on scala collections in Scala 2.12, it's a library that it's used in a lot of other Scala libraries. Plus, for Scala 2.13 & 3 this library contains just an empty package so we're not adding anything to users classpaths.

WDUT @ghostdogpr @hearnadam @guizmaii?

@kyri-petrou kyri-petrou changed the title Remove usages of deprecated scala.collection.JavaConverters Add dependency to scala-collection-compat and remove deprecated usages of scala.collection.JavaConverters Apr 10, 2025
@kyri-petrou kyri-petrou requested a review from guizmaii April 10, 2025 07:43
@ghostdogpr
Copy link
Member

Eghh so scala.jdk.CollectionConverters._ is only available when the scala-collection-compat library is present.

I think it's time to include it as a dependency; besides having to write unoptimized or lots of custom code to accommodate for methods on scala collections in Scala 2.12, it's a library that it's used in a lot of other Scala libraries. Plus, for Scala 2.13 & 3 this library contains just an empty package so we're not adding anything to users classpaths.

WDUT @ghostdogpr @hearnadam @guizmaii?

I'm fine with adding the dependency πŸ‘

@guizmaii
Copy link
Member

I'm fine with adding the dependency πŸ‘

Same. Necessary evil while we maintain compatibility with Scala 2.12

@kyri-petrou kyri-petrou merged commit 6f81114 into zio:series/2.x Apr 10, 2025
18 checks passed
@kyri-petrou kyri-petrou deleted the remove-deprecated-java-converters branch April 10, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants