Optimize Chunk::findZIO
#9784
Merged
Optimize Chunk::findZIO
#9784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
reviewed
Apr 14, 2025
| if (iterator.hasNextAt(index)) { | ||
| val a = iterator.nextAt(index) | ||
| index += 1 | ||
| def loop(iterator: Chunk.ChunkIterator[A]): ZIO[R, E, Option[A]] = |
Contributor
There was a problem hiding this comment.
This could be changed to use a lazy val instead:
lazy val loop: ZIO[R, E, Option[A]]PS: I'm actually not sure which one would be better performance-wise. lazy vals require a volatile read, however in Scala 3 we could use the @threadUnsafe annotation for such use-cases which use plain vars in the implementation. As for Scala 2, we'd have to stub it.
Member
Author
There was a problem hiding this comment.
@kyri-petrou What do you think about doing this in another PR, maybe? It seems a quite bigger change
kyri-petrou
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.