Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ZIO.fromFunctionZIO #9782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

Add ZIO.fromFunctionZIO #9782

merged 1 commit into from
Apr 21, 2025

Conversation

@adrian-2414745
Copy link
Contributor

@adrian-2414745 adrian-2414745 commented Apr 13, 2025 •
edited
Loading

Just like ZLayer.fromFunction.

The main pain point which triggered me was that in ZIO test i had to access all services individually

test() {
  a <- ZIO.service[A]
  b <- ZIO.service[b]
  // use a and b
}

now it is possible to get many services in one go

test() { 
  ZIO.fromFunction { (a: A, b: B) =>
     //use a and b
  }
}

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

hearnadam
hearnadam reviewed Apr 13, 2025
View reviewed changes
kyri-petrou
kyri-petrou reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@kyri-petrou kyri-petrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Too bad we'll have overlap between ZIO.serviceWith and ZIO.fromFunction for the Function1 case but I think that should be OK

@kyri-petrou
Copy link
Contributor

One more comment: Can we rename this method to fromFunctionZIO to keep naming aligned with ZIO.fromServiceZIO? We potentially want to also add fromFunction where the method something that is not effectual.

@adrian-2414745 adrian-2414745 force-pushed the series/2.x branch 3 times, most recently from 0fb8d38 to 567c671 Compare April 15, 2025 08:21
hearnadam
hearnadam reviewed Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@hearnadam hearnadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change overall LGTM - though it appears you had a faulty merge, including some other commits in your history.

@adrian-2414745

This comment was marked as outdated.

Sign in to view
@adrian-2414745 adrian-2414745 force-pushed the series/2.x branch 2 times, most recently from 8cee651 to b81d3fd Compare April 15, 2025 14:07
@adrian-2414745

This comment was marked as resolved.

Sign in to view
@hearnadam
Copy link
Collaborator

@adrian-2414745 can you run fmt?

@adrian-2414745

This comment was marked as outdated.

Sign in to view
kyri-petrou
kyri-petrou reviewed Apr 16, 2025
View reviewed changes
kyri-petrou
kyri-petrou reviewed Apr 17, 2025
View reviewed changes
kyri-petrou
kyri-petrou reviewed Apr 17, 2025
View reviewed changes
core/shared/src/main/scala/zio/ZIOFunctionConstructor.scala Outdated

type WithOut[In, Out0] = ZIOFunctionConstructor[In] { type Out = Out0 }

implicit def function1Constructor[A: Tag, R, E, Z: Tag]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed my previous comment. The : Tag on Z is unnecessary as far as I can tell (in this and other methods)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed it. done

kyri-petrou
kyri-petrou approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@kyri-petrou kyri-petrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks like a great addition!

@kyri-petrou kyri-petrou merged commit 8da126a into zio:series/2.x Apr 21, 2025
18 checks passed
@kyri-petrou kyri-petrou changed the title Add ZIO.fromFunction Add ZIO.fromFunctionZIO Apr 21, 2025
@kyri-petrou kyri-petrou mentioned this pull request Apr 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hearnadam hearnadam hearnadam approved these changes

@kyri-petrou kyri-petrou kyri-petrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@adrian-2414745 @CLAassistant @kyri-petrou @hearnadam