Clean ChannelExecutor::restorePipe and its usages
#9797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9decfd3 to
f91f36c
Compare
guizmaii
commented
Apr 15, 2025
| input = leftExec | ||
|
|
||
| addFinalizer { exit => | ||
| val effect = restorePipe(exit, previousInput) |
There was a problem hiding this comment.
effect can never be null
guizmaii
commented
Apr 15, 2025
| if (effect ne null) effect | ||
| else ZIO.unit | ||
| } | ||
| ZIO.suspendSucceed(restorePipe(exit, inputExecutor)) |
There was a problem hiding this comment.
Not convinced the ZIO.suspendSucceed is needed 🤔
Kept it as a conservative move
There was a problem hiding this comment.
It's not necessary since this will be in a flatMap.
There was a problem hiding this comment.
Took a second look and there was more useless stuff. See 8399ae6
ChannelExecutor::restorePipe and its usagesChannelExecutor::restorePipe and its usages
kyri-petrou
approved these changes
Apr 26, 2025
kyri-petrou
reviewed
Apr 26, 2025
| input = prev | ||
|
|
||
| if (currInput ne null) currInput.close(exit) else ZIO.unit | ||
| if (currInput ne null) currInput.close(exit) else Exit.unit |
There was a problem hiding this comment.
Minor suggestion, but maybe we should change addFinalizer so that it doesn't push the finalizer in the stack in case that it's eq Exit.unit (or even .isInstanceOf[Exit.Success[?]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.