Optimize foreachExec and underlying private foreach* methods
#9804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
reviewed
Apr 18, 2025
Comment on lines
+6317
to
+6318
| else if (parallelism >= size) | ||
| foreachParUnboundedDiscard(as, size)(f) |
There was a problem hiding this comment.
does this need to be a distinct branch? Wouldn't val nWorkers = parallelism.min(size) take care of this?
There was a problem hiding this comment.
This is more optimal because in this branch we don't have to go through polling via the queue. But you're right this makes val nWorkers = parallelism.min(size) obsolete, we can simply use parallelism with this new implementation
hearnadam
reviewed
Apr 21, 2025
| * the result in a new `Collection[B]` using the specified execution strategy. | ||
| */ | ||
| final def foreachExec[R, E, A, B, Collection[+Element] <: Iterable[Element]](as: Collection[A])( | ||
| def foreachExec[R, E, A, B, Collection[+Element] <: Iterable[Element]]( |
There was a problem hiding this comment.
I assume final was unnecessary in the object?
hearnadam
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.