Fix double-counting of failures when joining Fibers #9812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
previously approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9742
Currently we could every fiber that results in a failure in runtime metrics as a failure. In cases were we join fibers (i.e., parallel ops) this results in double+ counting of failures as both fibers will show up as failures.
With this PR we filter the Cause and count failures only for the ones that originated from the current fiber (based on its id). However, this means that we won't be counting failures that are stackless (i.e.,
Exit.fail). After discussing this with @jdegoes, we agreed that this is OK asExit.failshould not be tracked as it's stackless.