[9390] - add tryAcquire to Semaphore #9825
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hearnadam Hi, I have closed previous approved PR #9600 and opened this one instead. |
hearnadam
approved these changes
Apr 26, 2025
| * releasing them after execution. Returns `None` if no permits were | ||
| * available. | ||
| */ | ||
| def tryWithPermit[R, E, A](zio: ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, Option[A]] = |
There was a problem hiding this comment.
Suggested change
| def tryWithPermit[R, E, A](zio: ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, Option[A]] = | |
| final def tryWithPermit[R, E, A](zio: ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, Option[A]] = |
There was a problem hiding this comment.
@hearnadam TSemaphore is a final class, hence all member of the class are effectively final by default. that is why final modifier is redundant
There was a problem hiding this comment.
| * releasing them after execution. Returns `None` if no permits were | ||
| * available. | ||
| */ | ||
| def tryWithPermits[R, E, A](n: Long)(zio: ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, Option[A]] = |
There was a problem hiding this comment.
Suggested change
| def tryWithPermits[R, E, A](n: Long)(zio: ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, Option[A]] = | |
| final def tryWithPermits[R, E, A](n: Long)(zio: ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, Option[A]] = |
| * Tries to acquire the specified number of permits in a transactional | ||
| * context. Returns `true` if the permits were acquired, otherwise `false`. | ||
| */ | ||
| def tryAcquireN(n: Long): USTM[Boolean] = |
There was a problem hiding this comment.
Suggested change
| def tryAcquireN(n: Long): USTM[Boolean] = | |
| final def tryAcquireN(n: Long): USTM[Boolean] = |
| * Tries to acquire a single permit in a transactional context. Returns `true` | ||
| * if the permit was acquired, otherwise `false`. | ||
| */ | ||
| def tryAcquire: USTM[Boolean] = tryAcquireN(1L) |
There was a problem hiding this comment.
Suggested change
| def tryAcquire: USTM[Boolean] = tryAcquireN(1L) | |
| final def tryAcquire: USTM[Boolean] = tryAcquireN(1L) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tryAcquire to Semaphore and TSemaphore as per Issue #9390