Fix race condition when interrupting applications #9827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
previously approved these changes
Apr 28, 2025
| fiber <- workflow.interruptible.exitWith { exit0 => | ||
| val exitCode = if (exit0.isSuccess) ExitCode.success else ExitCode.failure | ||
| // If we're shutting down due to an external signal, the shutdown hook will fulfill the promise | ||
| // Otherwise it means we're shutting down due to normal completion and we need to fulfill the promise |
There was a problem hiding this comment.
leftover promise comments?
| "Check the logs for more details and consider overriding `Runtime.reportFatal` to capture context." | ||
| ) | ||
| } else { | ||
| try { |
There was a problem hiding this comment.
Does this still need to be in a try?
There was a problem hiding this comment.
There is an extremely low chance (I can't reproduce, but theoretically it might be possible), that the submission of the task to the executor is rejected (due to shutdown) and throws a RejectedExecutionException.
As I said, I'm not even sure if that's possible but just wanted to be extra safe just in case
There was a problem hiding this comment.
I added a comment to clarify
This was referenced May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9807
The main issue here is that in cases where the shutdown hooks were taking some time to process, the
fiber.joinwould win the race and the thrown Exception (in this case the interruption exception) would be thrown in the main thread. The fix is to make sure that all errors inworkfloware caught (by usingexitWithinstead ofonExit, and gracefully close the application withexit(exitCode)after we join the forked fiber.I also made some cleanups in the logic so that it's easier to follow, since the code previously relied on unsafely running effects unnecessarily and was harder to follow terms of what was executed in what sequence