fix assertTrue on new instance creation #9832
Conversation
bfa29b8 to
9a60206
Compare
| object SmartAssertionScala3Spec extends ZIOBaseSpec { | ||
|
|
||
| override def spec = | ||
| suite("SmartAssertionScala3Spec")( |
There was a problem hiding this comment.
Should this only contain Scala 3 specific tests? Do we need the overlap with SmartAssertionSpec?
There was a problem hiding this comment.
Yes, only specific to scala 3 test cases.
- trait with parameters
- inlines
- assertTrue with anonymous classes not compiled with scala 2 and it looked like scala 2 problem itself
If you have any suggestions on improving it - I can do it
There was a problem hiding this comment.
Ah, I didn't think about traits with parameters not being available on Scala 2. Thanks for the clarification.
| .find(f => f.name == name) | ||
| .orElse(s.methodMember(name).filter(_.declarations.nonEmpty).headOption) | ||
| .getOrElse( | ||
| throw new Error(s"Could not resolve $name on ${owner.show(using Printer.TreeStructure)}") |
There was a problem hiding this comment.
Is it possible to use reportErrorAndAbort? Is it also possible to test these failure cases, or do we expect them to be unreachable (for now)?
There was a problem hiding this comment.
Sure, I'll change it.
This should be unreachable if chosen TypeRepr if correct, because we know here that was selected a val or a method without arguments, so it should exist. It can be reachable only in case of incorrect implementation.
This PR improves support for creation of new objects in
assertTruemacro in case of overloaded methodsThere were several problems:
Block(List(cls: ClassDef), term)and it has no symbol. So we catch it and take correct symbol.Typed(Block(List(cls: ClassDef), term), _)and it has no symbol too. Solution is same, but also I usedunderlyingArgumentto removeInlinednodes.Also:
getFieldOrMethodto remove some boilerplate. Now it acceptsTypeReprand takes itstypeSymbol. Note that it affects one of cases wherelhs.symbolwas used and now it islhs.tpe.typeSymbol. IMO usinglhs.symbolis not correct and I'm sure about it - if you think I'm wrong, we can discuss it.inline.#9683