Improve the precision of ClockLive#currentTime
#9963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hearnadam
previously approved these changes
Jun 11, 2025
kyri-petrou
commented
Jun 11, 2025
Comment on lines
246
to
255
| private def toChronoUnit(unit: TimeUnit): ChronoUnit = | ||
| (unit: @switch) match { | ||
| case TimeUnit.NANOSECONDS => ChronoUnit.NANOS | ||
| case TimeUnit.MICROSECONDS => ChronoUnit.MICROS | ||
| case TimeUnit.MILLISECONDS => ChronoUnit.MILLIS | ||
| case TimeUnit.SECONDS => ChronoUnit.SECONDS | ||
| case TimeUnit.MINUTES => ChronoUnit.MINUTES | ||
| case TimeUnit.HOURS => ChronoUnit.HOURS | ||
| case TimeUnit.DAYS => ChronoUnit.DAYS | ||
| } |
There was a problem hiding this comment.
@hearnadam the toChronoUnit isn't implemented in JS / Native (I'm guessing it's because it was added in JDK9) so I added a method to manually map it. The implementation is the same as in the java library
There was a problem hiding this comment.
Egh... Annoyingly @switch doesn't work with java enums in Scala 🤦
We can either leave it as a non-switch statement or implement it separately for JS / Native. WDUT?
There was a problem hiding this comment.
Ah, that makes sense. Thanks
There was a problem hiding this comment.
Went with a platform-specific syntax, since the method already exists on the JVM it didn't make sense to re-implement it
hearnadam
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9960