Optimize error path in FiberRuntime
#9975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Jun 16, 2025
| } | ||
|
|
||
| case updateFlags: ZIO.UpdateRuntimeFlags => | ||
| cur = patchRuntimeFlags(updateFlags.update, cause, null) |
There was a problem hiding this comment.
This would have previously:
- Allocated an
Exit.Failureunnecessarily - Set
cur = Exit.Failure(cause)which means we would have to exit the inner loop (due to thecur ne nullcondition), only so that we would do another loop of the outer loop to end back at theExit.Failurecase
kyri-petrou
commented
Jun 16, 2025
| val size = _stackSize // racy | ||
|
|
||
| builder += _lastTrace | ||
| var last = _lastTrace |
There was a problem hiding this comment.
Much more performant to keep the last variable in the stack memory instead of checking it in StackTraceBuilder which kept it in the heap
hearnadam
previously approved these changes
Jun 16, 2025
| private def patchRuntimeFlags[R, E0, A0]( | ||
| patch: RuntimeFlags.Patch, | ||
| cause: Cause[E0], | ||
| continueEffect: ZIO[R, E0, A0] |
There was a problem hiding this comment.
Is this only used with Exit? Maybe we should make the types show that.
There was a problem hiding this comment.
Yeap, good point, changed 👍
guizmaii
reviewed
Jun 18, 2025
| builder += id.location // TODO: Allow parent traces? | ||
| val loc = id.location | ||
| if (loc ne last) | ||
| builder += id.location // TODO: Allow parent traces? |
There was a problem hiding this comment.
Suggested change
| builder += id.location // TODO: Allow parent traces? | |
| builder += loc // TODO: Allow parent traces? |
There was a problem hiding this comment.
Good point, thanks!
hearnadam
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor optimizations in this PR:
lastvariable when de-dupping traces in stack memory instead of the heap.Exit.Failure(see comment below)