Publish tests JAR #1005
Merged
Publish tests JAR #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TestRuntime` is inherited by multiple tests throughout the codebase. While it would be better to move it to `testkit`, such change would create cyclic dependency between the modules. Instead, core's tests are published as separate JAR reachable via classifier "tests".
jdegoes
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestRuntimeis inherited by multiple tests throughout the codebase.While it would be better to move it to
testkit, such change wouldcreate cyclic dependency between the modules. Instead, core's tests are
published as separate JAR reachable via classifier "tests".