Make Chunk::Singleton more lightweight
#10066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`length` doesn't need to be a `val` as it's a constant
guizmaii
commented
Jul 31, 2025
| implicit val classTag: ClassTag[A] = | ||
| Tags.fromValue(a) | ||
|
|
||
| override val length = |
There was a problem hiding this comment.
Any reason to prefer having a val here? 🤔
There was a problem hiding this comment.
Should not be for primitive constants
hearnadam
approved these changes
Jul 31, 2025
|
Looks good👍 |
plokhotnyuk
approved these changes
Jul 31, 2025
guizmaii
added a commit
that referenced
this pull request
Aug 5, 2025
guizmaii
added a commit
that referenced
this pull request
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lengthdoesn't need to be avalas it's a constant