Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optimise zio.stream.ZChannel::mapOutZIOParUnordered code #10080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: series/2.x
Choose a base branch
from
Open

Optimise zio.stream.ZChannel::mapOutZIOParUnordered code #10080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 84 additions & 70 deletions streams/shared/src/main/scala/zio/stream/ZChannel.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package zio.stream

import zio.{ZIO, _}
import zio.stacktracer.TracingImplicits.disableAutoTrace
import zio.stream.internal.ChannelExecutor.ChannelState
import zio.stream.internal.{AsyncInputConsumer, AsyncInputProducer, ChannelExecutor, SingleProducerAsyncInput}
import zio.{ZIO, _}

import java.util.concurrent.atomic.AtomicReference

Expand Down Expand Up @@ -755,81 +755,95 @@ sealed trait ZChannel[-Env, -InErr, -InElem, -InDone, +OutErr, +OutElem, +OutDon
*/
final def mapOutZIOParUnordered[Env1 <: Env, OutErr1 >: OutErr, OutElem2](n: Int, bufferSize: Int = 16)(
f: OutElem => ZIO[Env1, OutErr1, OutElem2]
)(implicit trace: Trace): ZChannel[Env1, InErr, InElem, InDone, OutErr1, OutElem2, OutDone] =
)(implicit trace: Trace): ZChannel[Env1, InErr, InElem, InDone, OutErr1, OutElem2, OutDone] = {
sealed trait ResultUnordered
object ResultUnordered {
final case class Value(value: OutElem2) extends ResultUnordered
final case class Done(done: OutDone) extends ResultUnordered
final case object Failure extends ResultUnordered
}

ZChannel.unwrapScopedWith { scope =>
for {
input <- SingleProducerAsyncInput.make[InErr, InElem, InDone]
queueReader = ZChannel.fromInput(input)
outgoing <- Queue.bounded[Exit[Either[Unit, OutDone], OutElem2]](bufferSize)
_ <- scope.addFinalizer(outgoing.shutdown)
errorSignal <- Promise.make[Nothing, Unit]
permits <- Semaphore.make(n.toLong)
failure = Ref.unsafe.make[Cause[OutErr1]](Cause.empty)(Unsafe)
pull <- (queueReader >>> self).toPullInAlt(scope)
childScope <- scope.fork
fiberId <- ZIO.fiberId
_ <-
pull.flatMap { outElem =>
val latch = Promise.unsafe.make[Nothing, Unit](fiberId)(Unsafe)
for {
_ <- permits
.withPermit(
latch.succeedUnit *> f(outElem)
.foldCauseZIO(
cause => {
val continue =
errorSignal.succeedUnit *>
outgoing.offer(ZChannel.failLeftUnit)

if (cause.isInterruptedOnly) continue
else failure.update(_ && cause) *> continue
},
elem => outgoing.offer(Exit.succeed(elem))
)
)
.interruptible
.forkIn(childScope)
_ <- latch.await
} yield ()
}.forever.interruptible
.onError(_.failureOrCause match {
case Left(x: Left[OutErr, OutDone]) =>
failure.update(_ && Cause.fail(x.value)) *>
outgoing.offer(ZChannel.failLeftUnit)
case Left(x: Right[OutErr, OutDone]) =>
permits.withPermits(n.toLong)(ZIO.unit).interruptible *>
outgoing.offer(Exit.fail(x.asInstanceOf[Either[Unit, OutDone]]))
case Right(cause) =>
val continue = outgoing.offer(ZChannel.failLeftUnit)

if (cause.isInterruptedOnly) continue
else failure.update(_ && cause) *> continue
})
.ignore
.raceFirst(ZChannel.awaitErrorSignal(childScope, fiberId)(errorSignal))
.forkIn(scope)
} yield {
lazy val writer: ZChannel[Env1, Any, Any, Any, OutErr1, OutElem2, OutDone] =
ZChannel.unwrap[Env1, Any, Any, Any, OutErr1, OutElem2, OutDone] {
outgoing.take.flatMap {
case s: Exit.Success[OutElem2] => Exit.succeed(ZChannel.write(s.value) *> writer)
case f: Exit.Failure[Either[Unit, OutDone]] =>
val failure0 = failure.unsafe.get(Unsafe)
val out = f.cause.failureOrCause match {
case Left(_: Left[Unit, OutDone]) => ZChannel.refailCause(failure0)
case Left(x: Right[Unit, OutDone]) =>
if (failure0 eq Cause.empty) ZChannel.succeedNow(x.value)
ZIO.fiberIdWith { fiberId =>
val input = SingleProducerAsyncInput.unsafe.make[InErr, InElem, InDone](fiberId)(Unsafe)
val queueReader = ZChannel.fromInput(input)
val n0 = n.toLong
val bufferSize0 = bufferSize
val outgoing = Queue.unsafe.bounded[ResultUnordered](bufferSize0, fiberId)(Unsafe)
val errorSignal = Promise.unsafe.make[Nothing, Unit](fiberId)(Unsafe)
val permits = Semaphore.unsafe.make(n0)(Unsafe)
val failure = Ref.unsafe.make[Cause[OutErr1]](Cause.empty)(Unsafe)

val setFinalizer: UIO[Unit] =
ZIO.uninterruptible {
scope.addFinalizer(outgoing.shutdown)
}

for {
_ <- setFinalizer
pull <- (queueReader >>> self).toPullInAlt(scope)
childScope <- scope.fork
processElems = pull.flatMap { outElem =>
val latch = Promise.unsafe.make[Nothing, Unit](fiberId)(Unsafe)

permits
.withPermit(
latch.succeedUnit *>
f(outElem)
.foldCauseZIO(
cause => {
val continue =
errorSignal.succeedUnit *>
outgoing.offer(ResultUnordered.Failure)

if (cause.isInterruptedOnly) continue
else failure.update(_ && cause) *> continue
},
elem => outgoing.offer(ResultUnordered.Value(elem))
)
)
.interruptible
.forkIn(childScope) *> latch.await
}.forever.interruptible
.onError(_.failureOrCause match {
case Left(x: Left[OutErr, OutDone]) =>
failure.update(_ && Cause.fail(x.value)) *>
outgoing.offer(ResultUnordered.Failure)
case Left(x: Right[OutErr, OutDone]) =>
permits.withPermits(n0)(ZIO.unit).interruptible *>
outgoing.offer(ResultUnordered.Done(x.value))
case Right(cause) =>
failure.update(_ && cause).unless(cause.isInterruptedOnly) *>
outgoing.offer(ResultUnordered.Failure)
})
.ignore

_ <- (processElems raceFirst ZChannel.awaitErrorSignal(childScope, fiberId)(errorSignal)).forkIn(scope)
} yield {
lazy val writer: ZChannel[Env1, Any, Any, Any, OutErr1, OutElem2, OutDone] =
ZChannel.unwrap[Env1, Any, Any, Any, OutErr1, OutElem2, OutDone] {
outgoing.take.flatMap {
case s: ResultUnordered.Value => Exit.succeed(ZChannel.write(s.value) *> writer)
case d: ResultUnordered.Done =>
val failure0 = failure.unsafe.get(Unsafe)
val out =
if (failure0 eq Cause.empty) ZChannel.succeedNow(d.done)
else ZChannel.refailCause(failure0)
case Right(c) if c.isInterruptedOnly => ZChannel.refailCause(failure0)
case Right(cause) => ZChannel.refailCause(cause)
}
outgoing.shutdown.as(out)

outgoing.shutdown.as(out)
case ResultUnordered.Failure =>
val failure0 = failure.unsafe.get(Unsafe)
val out = ZChannel.refailCause(failure0)

outgoing.shutdown.as(out)
}
}
}

writer.embedInput(input)
writer.embedInput(input)
}
}
}
}

/**
* Returns a new channel which creates a new channel for each emitted element
Expand Down