Fix OOM issue in ZPipeline#encodeStringWith
#10011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyri-petrou
commented
Jul 6, 2025
| def endOfInput(): Chunk[Byte] = { | ||
| @tailrec | ||
| def loop(acc: Chunk[Byte] = Chunk.empty): Chunk[Byte] = { | ||
| charBuffer.flip() |
Contributor
Author
There was a problem hiding this comment.
This is the main fix. Everything else is optimizations
guizmaii
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #9935
/claim #9935
Main issue is that
charBuffer.flip()was being called just once (see comment below), so in case that we couldn't drain thecharBufferin a single iteration, we were not flipping it in the next iteration causing an infinite loop (and eventually an OOM error).I also took the opportunity to re-write this method using tail recursion instead of ZIO recursion which should be far more performant