Make ZIO.Parallelism non-lazy
#10144
Conversation
|
Seems there was a class-loading issue if we made it into a val and kept it in the ZIO companion object, so I moved it to |
| FiberRef.unsafe.makeSupervisor(Runtime.defaultSupervisor)(Unsafe.unsafe) | ||
|
|
||
| private[zio] val parallelism: FiberRef[Option[Int]] = | ||
| FiberRef.unsafe.make[Option[Int]](None)(Unsafe) |
There was a problem hiding this comment.
Could we use a negative number to represent unbounded?
There was a problem hiding this comment.
I think it might end up being worse due to unboxing (and then boxing) of the not defined case (i.e., -1). If we're going to optimize it, it might be better to have a specialized OptionInt to avoid boxing / unboxing of the Int.
There was a problem hiding this comment.
Actually we'd have an issue with binary compatibility since ZIO.Parallelism was public.
There was a problem hiding this comment.
I was suggesting:
private[zio] val parallelism: FiberRef[java.lang.Integer] =
FiberRef.unsafe.make[java.lang.Integer](-1)(Unsafe)You can then have a method to map to the optional variant which of course can be deprecated...
However, I understand if this is more than you want to take on.
There was a problem hiding this comment.
We don't have a way to map / contramap a FiberRef unfortunately. Let's potentially tackle this at a later stage after we release with ZIO.Parallelism deprecated
Co-authored-by: Adam Hearn <[email protected]>
| */ | ||
| final lazy val Parallelism: FiberRef[Option[Int]] = | ||
| FiberRef.unsafe.make[Option[Int]](None)(Unsafe) | ||
| def Parallelism: FiberRef[Option[Int]] = |
There was a problem hiding this comment.
Can we make this deprecated + package private?
There was a problem hiding this comment.
Unfortunately making it package-private is not binary compatible in Scala 2.13 as the generated method becomes non-static (!?) 😞
No need for it to be lazy, it only adds overhead