zio-test: Ignored annotated suites should not trigger shared layer creation #10234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fde50d0 to
caa3e4a
Compare
851a773 to
86dd7be
Compare
bb4d5ff to
44f562c
Compare
44f562c to
6755420
Compare
Contributor
|
Could you provide an explanation on why / how this works? It's not obvious to me how this change affects the behaviour w.r.t. tags |
kyri-petrou
reviewed
Nov 18, 2025
Comment on lines
350
to
364
| Spec.scoped[R0] { | ||
| ZIO.scopeWith { scope => | ||
| import Spec.RichLayer | ||
|
|
||
| val scopedLayer: ZLayer[R0, E1, R] = | ||
| ZLayer.makeSome[R0, R]( | ||
| ZLayer.succeed(scope), | ||
| layer.extendScope | ||
| ) | ||
|
|
||
| scopedLayer.memoizeWithinScope(scope).map { memoizedLayer => | ||
| Spec.multiple(specs.map(_.provideLayer(memoizedLayer))) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Let's try to reuse memoize to avoid code duplication. Also let's chain the methods together, creating a separate val for the scoped layer feels like it should be used more than once:
Spec.scoped[R0] {
ZIO.scopeWith { scope =>
ZLayer
.makeSome[R0, R](
ZLayer.succeed(scope),
layer.extendScope
)
.memoize
.map { memoizedLayer =>
Spec.multiple(specs.map(_.provideLayer(memoizedLayer)))
}
}
}
Comment on lines
551
to
563
| Spec.scoped[R0] { | ||
| ZIO.scopeWith { scope => | ||
| val scopedLayer: ZLayer[R0, E1, R1] = | ||
| ZLayer.makeSome[R0, R1]( | ||
| ZLayer.succeed(scope), | ||
| layer.extendScope | ||
| ) | ||
|
|
||
| scopedLayer.memoizeWithinScope(scope).map { memoizedLayer => | ||
| Spec.multiple(specs.map(_.provideSomeLayer[R0](memoizedLayer))) | ||
| } | ||
| } | ||
| } |
Comment on lines
588
to
595
| private implicit final class RichLayer[RIn, E0, ROut](private val layer: ZLayer[RIn, E0, ROut]) extends AnyVal { | ||
|
|
||
| /** | ||
| * Version of `ZLayer::memoize` that uses the provided scope. | ||
| */ | ||
| def memoizeWithinScope(scope: Scope)(implicit trace: Trace): ZIO[Any, Nothing, ZLayer[RIn, E0, ROut]] = | ||
| layer.build(scope).memoize.map(ZLayer.fromZIOEnvironment(_)) | ||
| } |
kyri-petrou
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to ignore some tests by tagging them and use
-ignore-tags <tag>But I noticed that if my tests use
.provideSharedthen the layers inside are launched even if my entire suite (including the.provideShared) is flagged to not be run.Example:
Before the changes in this PR, the
TestContainersPG.layerwas always started, even if I launched my tests with the-ignore-tags dontRunoptionWith these changes, the
TestContainersPG.layeris not started when I launch my tests with with the-ignore-tags dontRunoption 🎉My test launched in an env without Docker before these changes:
Same test with these changes: