Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optimise Semaphore: Use an optimised data structure to queue jobs #10382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guizmaii merged 8 commits into from
Jan 14, 2026
Merged

Optimise Semaphore: Use an optimised data structure to queue jobs #10382

guizmaii merged 8 commits into from
Jan 14, 2026

Conversation

@guizmaii
Copy link
Member

@guizmaii guizmaii commented Jan 13, 2026 •
edited
Loading

(Merged in: #10378)

@guizmaii guizmaii self-assigned this Jan 13, 2026
@guizmaii guizmaii mentioned this pull request Jan 13, 2026
Open
@guizmaii guizmaii force-pushed the opt_Semaphore_0 branch 5 times, most recently from 68824af to 76c5cce Compare January 13, 2026 01:55
guizmaii
guizmaii commented Jan 13, 2026
View reviewed changes
core/shared/src/main/scala/zio/Semaphore.scala
ZIO.suspendSucceed {
val promises = ref.unsafe.modify(loop(n, _, Nil))
if (promises.isEmpty) Exit.unit
else ZIO.foreachDiscard(promises)(_.succeedUnit)
Copy link
Member Author

@guizmaii guizmaii Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefering the execute all the promise.succeedUnit calls with a ZIO.foreachDiscard instead of a chain of FlatMap

@guizmaii guizmaii marked this pull request as ready for review January 13, 2026 09:09
@guizmaii guizmaii merged commit ae05da8 into opt_Semaphore Jan 14, 2026
3 of 17 checks passed
@guizmaii guizmaii deleted the opt_Semaphore_0 branch January 14, 2026 04:14
guizmaii added a commit that referenced this pull request Jan 14, 2026
@guizmaii
Optimise Semaphore: Use an optimised data structure to queue jobs (#…
8585229 
…10382)

* Optimise `Semaphore`: Use an optimised data structure to queue jobs

* Optimise `releaseN` loop

* fmt

* Add test

* Clean tests

* Add more tests

* fmt

* Optimise `Semaphore`: Remove allocation of `Promise` when not needed (#10383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hearnadam hearnadam Awaiting requested review from hearnadam

@kyri-petrou kyri-petrou Awaiting requested review from kyri-petrou

Assignees

@guizmaii guizmaii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guizmaii