Optimise FiberRef::locallyScopedWith
#10304
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Again? 🤔 I thought I already did this here: #9483
hearnadam
reviewed
Dec 17, 2025
| * | ||
| * Guarantees that fiber data is properly restored via `acquireRelease`. | ||
| */ | ||
| def locallyWith[R, E, B](f: A => A)(zio: ZIO[R, E, B])(implicit trace: Trace): ZIO[R, E, B] = |
Collaborator
There was a problem hiding this comment.
You are changing locallyWith, but your title says locallyScopedWith.
This method is overriden in the child.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again? 🤔
I thought I already did this here: #9483
I didn't find in the history of this file why this code went back as it was (unoptimized) 🤔
https://github.com/zio/zio/commits/fda2d2e753c9266d79ff619b2d2da1f8c1318457/core/shared/src/main/scala/zio/FiberRef.scala