ZStream effectAsync and variants #1118
Conversation
|
Hi @iravid I have created a WIP PR for ZStream#effectAsync and variants to see if I am in the right ball park :-) |
|
@dariusrobson this is definitely on the right track! Looking great. I’ll try to review later tonight. Thanks for working on this! |
|
Great! Thank you for your comments @iravid. I have made some changes, let me know your thoughts :-) |
|
@dariusrobson Looks great. I've no more comments on the implementation, nice work! Can you look into the failing tests? Let me know if you need help hardening them. |
|
Thanks @iravid , I have put in a fix for the effectAsyncM test. The test_211_jdk8_jvm is failing for effectAsyncInterruptLeft and also for foreachParN - both for interruption (not sure if a coincidence). Any ideas on the cause? |
|
Looks good! @dariusrobson can you please rebase on master? |
|
Oh, and there's one last thing to be addressed: after you rebase/merge master, you'll see that we now have two objects: |
|
Cool. I have rebased and added the forwarding constructors to Stream. |
|
I will look into the failing test. |
|
Awesome 🎉 |
|
Thank you so much @dariusrobson for this contribution. Really great work. |
|
Thank you @iravid, I love the work you guys are doing. |
* Add ZStream.effectAsync and variants * Add canceler as finalizer for effectAsyncInterrupt * Set outputbuffer defaults to 16 * Cleanup docs * Formatting * Implement effectAsync in terms of effectAsyncMaybe * Eagerly shutdown the queue where not needed * Use UIO(...).toManaged_ for registration * Update effectAsyncM and effectAsyncInterruptRight tests * Cleanup * Fix effectAsyncM test * Use promise in effectAsyncInterrupt test * Remove non-flaky from StreamSpec * Add Stream forwarding constructors * Add effectAsyncInterrupt Stream constructor * Fix test and change StreamSpec references from ZStream to Stream
I thought I would create a WIP PR to make sure I am in the right ball park.
Places where I think I may need to make changes/improvements:
Resolves #1040