Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix #1003 Attach unsafeRun location to the stack trace #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2019
Merged

Fix #1003 Attach unsafeRun location to the stack trace #1133

merged 1 commit into from
Jul 7, 2019

Conversation

@neko-kai
Copy link
Member

@neko-kai neko-kai commented Jul 4, 2019

@neko-kai neko-kai requested review from ghostdogpr, iravid and jdegoes July 4, 2019 12:46
@neko-kai
Copy link
Member Author

neko-kai commented Jul 4, 2019 •
edited
Loading

tests failures in Streams on CircleCI...

[info]   Stream.mapMPar
[info]     + foreachParN equivalence
[error]     x interruption propagation
[error]  false != true (StreamSpec.scala:661)

@neko-kai neko-kai force-pushed the feature/fix-#1003-attach-unsafeRun-to-the-stacktrace branch from 719df10 to a553999 Compare July 7, 2019 13:18
@neko-kai neko-kai merged commit f704619 into zio:master Jul 7, 2019
@jdegoes
Copy link
Member

jdegoes commented Jul 7, 2019

@Kaishh Looks great to me and very useful! 👍

Did you look into why mdoc failed???

@neko-kai
Copy link
Member Author

neko-kai commented Jul 7, 2019

@jdegoes

Caused by: java.lang.NoSuchMethodError: zio.Runtime.unsafeRun(Lzio/ZIO;)Ljava/lang/Object;
	at zio.interop.reactiveStreams.QueueSubscriber$$anon$2.onSubscribe(QueueSubscriber.scala:71)
	at org.reactivestreams.example.unicast.RangePublisher.subscribe(RangePublisher.java:53)
	... 58 more

I think we'll need a new release & re-release interops due to bincompat change in unsafeRun (or I can add package-private shims for bincompat in a few hours)

@jdegoes
Copy link
Member

jdegoes commented Jul 7, 2019

@Kaishh Ah right. So you have to update interop first, then update this one again. We'll have to figure this out long term. Maybe website / docs has to be pulled out into a separate project.

@neko-kai
Copy link
Member Author

neko-kai commented Jul 7, 2019

Ok, released https://github.com/zio/zio/releases/tag/v1.0.0-RC9-3 let's see what happens

@neko-kai
Copy link
Member Author

neko-kai commented Jul 7, 2019

Failed with https://circleci.com/gh/zio/zio/5035

[error] Activity close started:2019-07-07T23:05:38.493Z, stopped:
[error]     Failed: pom-staging, failureMessage:Invalid POM: /dev/zio/zio-stacktracer_sjs0.6_2.11/1.0.0-RC9-3/zio-stacktracer_sjs0.6_2.11-1.0.0-RC9-3.pom: SCM URL missing

#1145

@neko-kai
Copy link
Member Author

neko-kai commented Jul 7, 2019

Trying again:
https://github.com/zio/zio/releases/tag/v1.0.0-RC9-4
https://circleci.com/workflow-run/12c9d73b-f232-4ec2-bb9d-b55cd030e9ac

@neko-kai neko-kai deleted the feature/fix-#1003-attach-unsafeRun-to-the-stacktrace branch July 7, 2019 23:34
@neko-kai
Copy link
Member Author

neko-kai commented Jul 7, 2019 •
edited
Loading

https://circleci.com/gh/zio/zio/5069

[info] Reading staging repository profiles...
[error] Multiple repositories are found:
[error] [devzio-1107] status:open, profile:dev.zio(ad33947a4dfa37) description: Implicitly created (auto staging).
[error] [devzio-1108] status:open, profile:dev.zio(ad33947a4dfa37) description: Implicitly created (auto staging).

🤦‍♀️
Ok, I need help now, someone with credentials should run sbt sonatypeDrop and restart the workflow. Sorry! @NeQuissimus @jdegoes

@ghostdogpr
Copy link
Member

@Kaishh done

@neko-kai
Copy link
Member Author

neko-kai commented Jul 8, 2019

@ghostdogpr Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdegoes jdegoes Awaiting requested review from jdegoes

@iravid iravid Awaiting requested review from iravid

@ghostdogpr ghostdogpr Awaiting requested review from ghostdogpr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@neko-kai @jdegoes @ghostdogpr