Add ZManaged.makeExit that allows to handle Exit by the finalizer.
#1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
previously approved these changes
Jul 27, 2019
There was a problem hiding this comment.
Thank you @vvlevykin, this looks good and would be a great addition to ZManaged!
|
This needs a rebase and a fix to mdoc and should be good to go! |
|
This example from the doc becomes clunky, what do you suggest instead of val data: IO[IOException, String] = for {
p <- Promise.make[IOException,File]
res = Reservation(openFile("x", p), _ => closeFile(p))
result <- (for {
fiber <- res.acquire.fork
ex <- fiber.interrupt
data <- ex.toEither.fold(e => IO.fail(new InterruptedIOException("Stop!")), file => readFile(file))
} yield data).ensuring(res.release(???))
} yield result |
|
@vvlevykin I'd just delete the entire section on that. |
iravid
approved these changes
Aug 1, 2019
|
Nicely done - thanks @vvlevykin! |
ghostdogpr
pushed a commit
to ghostdogpr/scalaz-zio
that referenced
this pull request
Aug 5, 2019
…io#1232) * Add ZManaged.makeExit that allows to handle `Exit` by the finalizer. * Update ZStream. * Add tests. * Fix formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1231.