Add error and environment combinators for ZStream #1427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes! |
6ffa3b4 to
3c14648
Compare
|
Awesome. We'll finally have this in 🎆 |
|
@iravid This is the look of things clicking into place. 😄 💪 |
jdegoes
reviewed
Aug 18, 2019
| for { | ||
| finalizer <- Ref.make[Exit[_, _] => ZIO[R1, Nothing, Any]](_ => UIO.unit).toManaged_ | ||
| _ <- ZManaged.finalizerExit(e => finalizer.get.flatMap(_.apply(e))) | ||
| selfInputStream <- Ref.make[InputStream[R, E, A]](InputStream.end).toManaged_ |
There was a problem hiding this comment.
This pattern occurs so pervasively I think we should write a combinator to handle it (finalizer?). Basically creating a Ref, with some default action, then running some code, updating the default, and finally ensuring the finalizer is run at the end. Could be reasonably nice to use with ZManaged, I think.
There was a problem hiding this comment.
Good idea. This looked like a combinator for ZManaged - ZManaged.finalizerRef.
jdegoes
reviewed
Aug 18, 2019
| * Provides the stream with its required environment, which eliminates | ||
| * its dependency on `R`. | ||
| */ | ||
| final def provide(r: R): Stream[E, A] = |
jdegoes
reviewed
Aug 18, 2019
| * | ||
| * See also [[ZStream#catchAll]]. | ||
| */ | ||
| final def orElse[R1 <: R, E2, A1 >: A](that: => ZStream[R1, E2, A1]): ZStream[R1, E2, A1] = |
jdegoes
reviewed
Aug 18, 2019
| def done[E, A](e: Exit[E, A]): InputStream[Any, E, A] = IO.done(e).mapError(Some(_)) | ||
| def fromPromise[E, A](p: Promise[E, A]): InputStream[Any, E, A] = p.await.mapError(Some(_)) | ||
|
|
||
| def sequenceCause[E](c: Cause[Option[E]]): Option[Cause[E]] = |
|
Awesome. Great job getting all those changes in. 🙏 🎉 |
b8afd68 to
e5a5f94
Compare
e5a5f94 to
79f9daa
Compare
jdegoes
reviewed
Aug 22, 2019
| * is yielded as the result of the effect, allowing for control flows that require | ||
| * mutating finalizers. | ||
| */ | ||
| final def finalizerRef[R]( |
jdegoes
reviewed
Aug 22, 2019
| * is yielded as the result of the effect, allowing for control flows that require | ||
| * mutating finalizers. | ||
| */ | ||
| final def finalizerRef[R]( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At last,
Resolves #634
Resolves #817
cc @runtologist @mschuwalow