Remove ZSink.Step in favor of abstract methods on Sink and update ZSink encoding #1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Sep 4, 2019
|
@iravid Ready for review, whenever you have time. |
iravid
reviewed
Sep 12, 2019
iravid
requested changes
Sep 12, 2019
6 tasks
|
@vasilmkd Amazing undertaking. ❤️ |
iravid
reviewed
Sep 13, 2019
fsvehla
pushed a commit
to fsvehla/zio
that referenced
this pull request
Sep 21, 2019
adamgfraser
added a commit
that referenced
this pull request
Nov 7, 2019
* implement permits * make TRef state private * prototype safe semaphore * implement permits * make TRef state private * #1219 - add doUntilEquals and doWhileEquals methods (#1634) * Update zio-interop-reactivestreams to 1.0.3.1-RC1 (#1665) * Add ZStream#cross, crossWith, <*>, <*, *>, <&>, zipLeft, zipRight, <&, &> (#1510) * Add ZStrem#zip left and right operators and alias for all zip operators * formatted code to make scalafmtCheck pass. * change for <*> variants with flatmap and <&> with zipWith. * adding crossWith and cross functions to ZStream. * merge conflict change. * formatted naming conventions. * Update the encoding of ZSink (#1560) * prototype safe semaphore * cleanup * uodate documentation * address review comments * cleanup * add back and deprecate methods * cleanup * make method private
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* implement permits * make TRef state private * prototype safe semaphore * implement permits * make TRef state private * zio#1219 - add doUntilEquals and doWhileEquals methods (zio#1634) * Update zio-interop-reactivestreams to 1.0.3.1-RC1 (zio#1665) * Add ZStream#cross, crossWith, <*>, <*, *>, <&>, zipLeft, zipRight, <&, &> (zio#1510) * Add ZStrem#zip left and right operators and alias for all zip operators * formatted code to make scalafmtCheck pass. * change for <*> variants with flatmap and <&> with zipWith. * adding crossWith and cross functions to ZStream. * merge conflict change. * formatted naming conventions. * Update the encoding of ZSink (zio#1560) * prototype safe semaphore * cleanup * uodate documentation * address review comments * cleanup * add back and deprecate methods * cleanup * make method private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #538, #1605, #1313.
All tests are passing with minimal changes (only where removing the
Stepapi was necessary). I have a feeling that the implementation of the more complicated combinators became much clearer by taking over the control flow of theSinkfrom theStepand encoding it into theSinkitself.Let me know what you think.
@iravid I will be available to make quick changes during the review.
cc @jdegoes