ZIO Test: Add Size Combinators #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostdogpr
previously approved these changes
Sep 8, 2019
jdegoes
reviewed
Sep 9, 2019
| * useful when the process to shrink a value is simpler than the process used | ||
| * to generate it. | ||
| */ | ||
| final def reshrink[R1 <: R, B](f: A => Sample[R1, B]): Gen[R1, B] = |
jdegoes
reviewed
Sep 9, 2019
| * Returns two raised to the specified power. If the specified power is | ||
| * negative returns zero. | ||
| */ | ||
| final def pow2(n: Int): Int = { |
jdegoes
reviewed
Sep 9, 2019
| * the nearest integer. If the specified integer is zero or negative returns | ||
| * zero. | ||
| */ | ||
| final def log2Ceil(n: Int): Int = { |
There was a problem hiding this comment.
Nothing like this in Scala / Java math lib?
jdegoes
reviewed
Sep 9, 2019
| * the nearest integer. If the specified integer is zero or negative returns | ||
| * zero. | ||
| */ | ||
| final def log2Floor(n: Int): Int = { |
There was a problem hiding this comment.
Can also compose logs and floor, right? e.g. here
jdegoes
requested changes
Sep 9, 2019
|
Yes I think you are right about the math combinators. I went down that road because all the logarithm and power operators use |
ghostdogpr
approved these changes
Sep 9, 2019
jdegoes
approved these changes
Sep 9, 2019
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
small,medium, andlargesized combinators for generators to generate a distribution of sizes based on the size parameter. Thelargecombinator mimics the current behavior and with the size configured at100generates uniform sizes between0and100. Themediumcombinator uses an exponential distribution and so generate values between0and100but with most values towards the smaller end of the range and some larger values. Thesmallcombinator uses a logarithmic distribution and generates values between0and7with the default configuration.I changed the collection generators like
listOfto use newmediumcombinator. I think this should be a win-win in terms of performance and test coverage. We will be generating fewer larger collections which should speed up tests. And there are a lot of bugs that can be easier to catch with smaller collections that I don't think we weren't testing enough before.Resolves #1601.