Add ZStreamChunk#buffer, ZStream.mergeAllUnbounded, ZStream.flattenPa… #1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c82134f to
4b469cb
Compare
| * @note Prefer capacities that are powers of 2 for better performance. | ||
| */ | ||
| final def buffer(capacity: Int): ZStreamChunk[R, E, A] = | ||
| ZStreamChunk(chunks.buffer(capacity)) |
There was a problem hiding this comment.
How about adding a dropping strategy?
jdegoes
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Looks good to me. Like @regiskuckaertz says, the dropping strategy could be useful. Don't see a super clean way to add the family but it's clear for every queue, there could be a corresponding buffer type.
|
@jdegoes @regiskuckaertz Yeah! We can add |
fsvehla
pushed a commit
to fsvehla/zio
that referenced
this pull request
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rUnbounded
A couple of combinators I needed for zio-kafka.