Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a synchronous effect construction for the ZManaged (#1666) #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 14, 2019
Merged

Add a synchronous effect construction for the ZManaged (#1666) #1667

merged 2 commits into from
Sep 14, 2019

Conversation

@LukaszByczynski
Copy link
Contributor

@LukaszByczynski LukaszByczynski commented Sep 13, 2019 •
edited by iravid
Loading

Resolves #1666.

iravid
iravid requested changes Sep 13, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LukaszByczynski! I suggested a few slight tweaks to the signature.

core/shared/src/main/scala/zio/ZManaged.scala Outdated
/**
* Lifts a synchronous effect into `ZManaged[R, E, R]` with a release action.
*/
final def makeEffect[R, E, A](acquire: => A)(release: A => _): ZManaged[R, E, A] =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final def makeEffect[R, E, A](acquire: => A)(release: A => _): ZManaged[R, E, A] =
final def makeEffect[R, A](acquire: => A)(release: A => _): ZManaged[R, Throwable, A] =

core/shared/src/main/scala/zio/ZManaged.scala Outdated
* Lifts a synchronous effect into `ZManaged[R, E, R]` with a release action.
*/
final def makeEffect[R, E, A](acquire: => A)(release: A => _): ZManaged[R, E, A] =
make(Task(acquire).orDie)(a => Task(release(a)).orDie)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
make(Task(acquire).orDie)(a => Task(release(a)).orDie)
make(Task(acquire))(a => Task(release(a)).orDie)

core/shared/src/main/scala/zio/Managed.scala Outdated
/**
* See [[zio.ZManaged.makeEffect]]
*/
final def makeEffect[E, A](acquire: => A)(release: A => _): Managed[E, A] =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final def makeEffect[E, A](acquire: => A)(release: A => _): Managed[E, A] =
final def makeEffect[A](acquire: => A)(release: A => _): Managed[Throwable, A] =

@LukaszByczynski
Copy link
Contributor Author

@iravid Thanks for the review. I did suggested changes

iravid
iravid approved these changes Sep 14, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LukaszByczynski! Looks good :-)

@iravid iravid merged commit 044418d into zio:master Sep 14, 2019
fsvehla pushed a commit to fsvehla/zio that referenced this pull request Sep 21, 2019
@LukaszByczynski @fsvehla
Add a synchronous effect construction for the ZManaged (zio#1666) (zi…
b7050b0 
…o#1667)

* Add a synchronous effect construction for the ZManaged (zio#1666)

* Changed error type to Throwable for makeEffect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add method that allows lift a synchronous effect into ZManaged

2 participants

@LukaszByczynski @iravid