Add ZSink.foldWeightedDecompose/M and fix leftover handling in transduce #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasilmkd
reviewed
Sep 14, 2019
| ): ZSink[Any, Nothing, A, A, S] = | ||
| new SinkPure[Nothing, A, A, S] { | ||
| type State = (S, Long, Boolean, Chunk[A]) | ||
| import internal.FoldWeightedState |
There was a problem hiding this comment.
Since we are starting to use ZSink.internal for complex states, it makes sense to restrict the old imports to only the needed types. Just a mental note.
vasilmkd
reviewed
Sep 14, 2019
| * of type `S`, until `max` worth of elements (determined by the `costFn`) | ||
| * have been folded. | ||
| * | ||
| * @note In case |
There was a problem hiding this comment.
Missing scaladoc? Same with foldWeighted.
vasilmkd
reviewed
Sep 14, 2019
| * of type `S`, until `max` worth of elements (determined by the `costFn`) have | ||
| * been folded. | ||
| */ | ||
| final def foldWeightedDecomposeM[R, R1 <: R, E, E1 >: E, A, S]( |
There was a problem hiding this comment.
We should document the decompose function better.
vasilmkd
reviewed
Sep 14, 2019
| */ | ||
| final def foldWeightedDecompose[A, S]( | ||
| z: S | ||
| )(costFn: A => Long, max: Long, decompose: A => Chunk[A] = Chunk.single[A](_))( |
There was a problem hiding this comment.
Scala 2.11 has trouble with this line.
|
Minor documentation comments. Have a written approval. 😄 |
vasilmkd
reviewed
Sep 14, 2019
| init <- sink.initial.toManaged_ | ||
| sinkStateRef <- Ref.make[(sink.State, Boolean)]((init, false)).toManaged_ | ||
| done <- Ref.make(false).toManaged_ | ||
| sink <- managedSink.map(_.mapError(Some(_))) |
fsvehla
pushed a commit
to fsvehla/zio
that referenced
this pull request
Sep 21, 2019
…uce (zio#1675) * Add ZSink.foldWeightedDecompose/M and fix leftover handling in transduce * 2.11 fixes * Improve docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1671
Resolves: #1673
@vasilmkd could you have a look?