Restore bracket on zio actions #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neko-kai
reviewed
Sep 17, 2019
| final def bracket: ZIO.BracketAcquire[R, E, A] = | ||
| new ZIO.BracketAcquire(self) | ||
|
|
||
| final def bracketExit: ZIO.BracketExitAcquire[R, E, A] = |
There was a problem hiding this comment.
this one is already there in fact 🧐
jdegoes
approved these changes
Sep 17, 2019
neko-kai
reviewed
Sep 17, 2019
| */ | ||
| def bracketAuto[R1 <: R, E1 >: E, B](use: A => ZIO[R1, E1, B]): ZIO[R1, E1, B] = | ||
| io.bracket(a => UIO(a.close()))(use) | ||
| io.bracket[R1, E1, B](a => UIO(a.close()), use) |
There was a problem hiding this comment.
Doesn't that look like a reason for invariant syntax to be there? 🤔
There was a problem hiding this comment.
I guess so 😟 then remove bracketExit from the main class too?
|
Probably so if we can show type inference issues... |
regiskuckaertz
pushed a commit
that referenced
this pull request
Sep 17, 2019
This reverts commit 178fad2.
|
I don't think it needs to be reverted: #1696 |
fsvehla
pushed a commit
to fsvehla/zio
that referenced
this pull request
Sep 21, 2019
* Restore zio.bracket shorthands * Drop invariant syntactic sugar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method existed only inside an implicit class for invariant types, but it doesn't seem necessary. Besides it's missing from the scaladoc which is quite surprising (since
bracket_is there).