Rename ZIO.aggregateWithin to ZIO.aggregateWithinEither and add a simpler aggregateWithin #1700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # streams-tests/jvm/src/test/scala/zio/stream/StreamSpec.scala
# Conflicts: # streams-tests/jvm/src/test/scala/zio/stream/StreamSpec.scala
|
Needs a rebase on master |
|
Finally, ready for your review, @iravid. |
vasilmkd
suggested changes
Sep 18, 2019
| * pulls. | ||
| */ | ||
| final def aggregateWithin[R1 <: R, E1 >: E, A1 >: A, B, C]( | ||
| final def aggregateWithinEither[R1 <: R, E1 >: E, A1 >: A, B, C]( |
There was a problem hiding this comment.
We will need to add some more documentation to this method, to highlight the difference compared to the new aggregateWithin which currently doesn't have a scaladoc.
There was a problem hiding this comment.
I appreciate your feedback! I've added ScalaDoc for both methods in a4b8851.
There was a problem hiding this comment.
@iravid Should we open an issue maybe for the hackathon, to add annotated documentation like this?
There was a problem hiding this comment.
See #413 where I started adding ScalaDoc to some files. It's a good first issue for a hackathon.
vasilmkd
approved these changes
Sep 18, 2019
fsvehla
pushed a commit
to fsvehla/zio
that referenced
this pull request
Sep 21, 2019
…pler aggregateWithin (zio#1700) * Added ScalaDoc to Ref * Add ScalaDoc to RefM * Add ScalaDoc to Queue * Add ScalaDoc to Fiber * zio#1567 Rename ZStream.aggregateWithin to aggregateWithinEither * Format * Fix StreamSpec::aggregateWithinEitherLeftoverHandling & aggregateWithin * Fix StreamSpec::aggregateWithinEitherLeftoverHandling * Add ScalaDoc to ZStream::aggregateWithin(Either)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1567