ZIO Test: Simplify TestAspect#around #1718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regiskuckaertz
previously approved these changes
Sep 21, 2019
|
Yes, @jdegoes came up with it. It is really nice. |
jdegoes
reviewed
Sep 21, 2019
| /** | ||
| * Constructs an aspect that evaluates every test inside the context of a `Managed`. | ||
| */ | ||
| def around[R0, E0](managed: ZManaged[R0, E0, Any]) = |
There was a problem hiding this comment.
Since the ZManaged returns Any, what about taking before and after directly, then we can wrap them into a managed inside this function and pass them to the other aroundTest? Less work for user.
There was a problem hiding this comment.
I like it. Let me make that change now.
|
Done. |
ghostdogpr
approved these changes
Sep 21, 2019
|
@jdegoes Are you good with this? |
|
Improvement to the default behavior, and breaking, but worth it, I think! |
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* simplify TestAspect#around * address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the type signature of
TestAspect#aroundso it becomes a combined version ofTestAspect#beforeandTestAspect#afterwhere thebeforeandaftereffects correspond to theacquireandreleaseeffects of the specifiedManaged. The existing version that also allows for modifying the test result goes toTestAspect#aroundTest.