Add ZStream#unNone #1713
Merged
Add ZStream#unNone #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't get the purpose of using extension methods if we have access to sources. What is the reason? There is only one method implemented as an extension. What makes it distinct from the others? Maybe it should be implemented as a method of a class? |
|
Thanks @asakaev! Keeping the methods on the class as you've done is preferable (better discoverability). Let's move |
|
Moving |
vasilmkd
approved these changes
Sep 20, 2019
iravid
approved these changes
Sep 21, 2019
|
@iravid my pleasure. I'm willing to donate review cycles, as you call them, generously for the duration of the hackathon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually using this technique, you have to write boilerplate code.
Inspired by @mpilquist implementation.