Add ZStream.bimap and either #1725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
reviewed
Sep 21, 2019
| /** | ||
| * Returns a stream whose failures and successes have been lifted into an | ||
| * `Either`.The resulting stream cannot fail, because the failures have | ||
| * been exposed as part of the `Either` success case. |
There was a problem hiding this comment.
Cool. Add a note that the resulting stream will emit the failure that occured, then end?
There was a problem hiding this comment.
Ha, right. Is that the correct behaviour? or instead we keep pulling even after error?
There was a problem hiding this comment.
Yes, that's what we do right now because the contract of Pull (currently!) doesn't allow for pulling after a failure.
iravid
requested changes
Sep 21, 2019
| * Creates a stream from a single value that will get cleaned up after the | ||
| * stream is consumed | ||
| */ | ||
| final def bracketExit[R, E, A]( |
|
@iravid done |
iravid
approved these changes
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gonna add new combinators as I see a need for them writing cats instances.
cc @iravid