Implement ZManaged#withEarlyRelease #1722
Conversation
| reserve.flatMap { | ||
| case Reservation(acquire, release) => | ||
| Ref.make(true).map { finalize => | ||
| val canceler = (release(Exit.interrupt) *> finalize.set(false)).uninterruptible |
There was a problem hiding this comment.
Oh right I forgot about release using an Exit[_, _]. How about we do 2 variants - withEarlyReleaseExit(Exit[_, _] => URIO) and withEarlyRelease?
I was going back and forth on defaulting to Exit.interrupt but I'm convinced this is good. Let's just add a note about that on the scaladoc.
| * A more powerful version of `withEarlyRelease` that allows specifying an | ||
| * exit value in the event of early release. | ||
| */ | ||
| final def withEarlyReleaseExit(exit: Exit[_, _]): ZManaged[R, E, (URIO[R, _], A)] = |
There was a problem hiding this comment.
How about renaming both to earlyRelease and earlyReleaseWith, this seems to be more in line with other combinators that have a more powerful version.
There was a problem hiding this comment.
I think maybe withEarlyRelease indicates more clearly that it is giving you an option to do early release but not actually doing it? And we do have other Exit variants like finalizer and finalizerExit. But that is super subjective. I'm fine with either one. @iravid What do you think?
There was a problem hiding this comment.
withEarlyRelease is probably more accurate as it "adds" the option to release early
Resolves #1697.