Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove specialized annotations #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2019
Merged

Remove specialized annotations #1738

merged 2 commits into from
Sep 21, 2019

Conversation

@regiskuckaertz
Copy link
Member

@regiskuckaertz regiskuckaertz commented Sep 21, 2019 •
edited
Loading

@iravid is there anything else required for this to be done?

Closes #1526

@adamgfraser
Copy link
Contributor

Nice! After this would be great to see what the other Dotty compatibility issues are, if any.

@regiskuckaertz
Copy link
Member Author

Sadly, that doesn't look so good:

object ChunkBox {
  val array: Array[Int] = Array(1, 2, 3, 4)
  val chunk: Chunk[Int] = Chunk.fromArray(array)
  val arrayOut: Array[Int] = chunk.toArray
}
public final class zio.ChunkBox {
  public static int[] arrayOut();
  public static zio.Chunk<java.lang.Object> chunk();
  public static int[] array();
}

@jdegoes
Copy link
Member

jdegoes commented Sep 21, 2019

@regiskuckaertz What is that boxing example from? Dotty?

@regiskuckaertz
Copy link
Member Author

regiskuckaertz commented Sep 21, 2019 •
edited
Loading

@jdegoes 2.12, actually after I learnt how to use javap 😅

27: astore_3
28: aload_3
29: invokeinterface #40,  1           // InterfaceMethod zio/Chunk.toArray:()Ljava/lang/Object;
34: checkcast     #42                 // class "[I"
37: astore        4
39: new           #12                 // class scala/collection/mutable/ArrayOps$ofInt
42: dup
43: getstatic     #47                 // Field scala/Predef$.MODULE$:Lscala/Predef$;
46: aload         4
48: invokevirtual #51                 // Method scala/Predef$.intArrayOps:([I)[I

@iravid
Copy link
Member

iravid commented Sep 21, 2019

@regiskuckaertz rebase please :-)

@regiskuckaertz
Copy link
Member Author

Done

iravid
iravid approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@iravid iravid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@iravid iravid merged commit c6c26ae into zio:master Sep 21, 2019
@regiskuckaertz regiskuckaertz deleted the rk-stream-specialized branch September 21, 2019 17:23
@ghostdogpr ghostdogpr mentioned this pull request Sep 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iravid iravid iravid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove specialization from Chunk in favor of distinct subtypes of Chunk.Arr

4 participants

@regiskuckaertz @adamgfraser @jdegoes @iravid